Skip to content

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Oct 8, 2025

On step 1 and in the drawer, adds the project selector. Preserves the project id when making a new automation.

image

On step 1 and in the drawer, adds the project selector. Preserves the project id when making a new automation.
@scttcper scttcper requested a review from a team as a code owner October 8, 2025 20:05
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 8, 2025
Copy link

codecov bot commented Oct 8, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12144 1 12143 10
View the top 1 failed test(s) by shortest run time
EditConnectedMonitors can connect an existing monitor
Stack Traces | 1.09s run time
Error: Unable to find an element with the text: Metric Monitor 1. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.findByText (.../automations/components/editConnectedMonitors.spec.tsx:43:26)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

const organization = useOrganization();
const {selection} = usePageFilters();

let project: number | undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just do const project = selection.projects?.find(...)?

to={`${makeAutomationBasePathname(organization.slug)}new/`}
to={{
pathname: `${makeAutomationBasePathname(organization.slug)}new/`,
query: project ? {project} : undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to change the link? Wouldn't the page filters store hydrate from localstorage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants